fix augeas pkg.url #845
Merged
fix augeas pkg.url #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcooper
reviewed
May 8, 2024
configs/components/augeas.rb
Outdated
| end | ||
|
|
||
| pkg.url "http://download.augeas.net/augeas-#{pkg.get_version}.tar.gz" | ||
| pkg.url "https://github.com/hercules-team/augeas/releases/download/release-#{pkg.get_version}/augeas-#{pkg.get_version}.tar.gz" |
Collaborator
There was a problem hiding this comment.
Looks like this broke in 9c6456a AFAIK, only 1.13.0+ is on github
h0tw1r3
force-pushed
the
fix/augeas-source
branch
2 times, most recently
from
52e5f91 to
eb42f9e
Compare
joshcooper
approved these changes
May 8, 2024
Collaborator
joshcooper
left a comment
joshcooper
left a comment
There was a problem hiding this comment.
not blocking but maybe add a comment that the fallback to download.augeas.net can be removed once we stop supporting augeas 1.12.0
versions after 1.12.0 are only available from Github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest versions are not available on download.augeas.net